feat!: multi areal request and geojson support #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
melancholiai
commented
Jun 27, 2023
melancholiai
commented
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✔ |
| Breaking change | ✔ |
| Deprecations | ✖ |
| Documentation | ✔ |
| Tests added | ✔ |
| Chore | ✖ |
syncush
requested changes
Jun 28, 2023
| properties: | ||
| message: | ||
| type: string | ||
| Geometry: |
Contributor
There was a problem hiding this comment.
I thought of having minZoom and maxZoom per feature while we can set a global minZoom and maxZoom if we didn't set
Contributor
Author
There was a problem hiding this comment.
thought about it too, but it was suggested that this might be prone to human error
Contributor
There was a problem hiding this comment.
what about setting a global?
Contributor
Author
There was a problem hiding this comment.
sounds like another level of complexity for not much, if a necessity comes I'm in favour to revisit this
syncush
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.