feat(auth-cron): add metrics MAPCO-8511#102
Merged
Merged
Conversation
netanelC
changed the title
|
🎫 Related Jira Issue: MAPCO-8511 |
CptSchnitz
requested changes
Aug 18, 2025
| import { metricsRegistry } from './telemetry/metrics'; | ||
|
|
||
| const LIVENESS_PORT = 8080; | ||
| const PORT = 8080; |
Contributor
There was a problem hiding this comment.
get the port from env if defined.
later integrate with the schema
Comment on lines
49
to
67
| const server = createServer((request, response) => { | ||
| response.end(`HELLO WORLD`); | ||
| if (request.url === '/metrics') { | ||
| metricsRegistry | ||
| .metrics() | ||
| .then((metrics) => { | ||
| response.setHeader('Content-Type', metricsRegistry.contentType); | ||
| response.end(metrics); | ||
| }) | ||
| .catch((err) => { | ||
| if (err instanceof Error) { | ||
| logger?.error({ msg: 'Failed to generate metrics', err }); | ||
| } | ||
| response.statusCode = 500; | ||
| response.end('Error generating metrics'); | ||
| }); | ||
| } else { | ||
| response.end('HELLO WORLD'); | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
dont you want to just install express and use the middleware from telemetry?
|
|
||
| const metricsRegistry = new Registry(); | ||
|
|
||
| collectMetricsExpressMiddleware({ registry: metricsRegistry }); |
Contributor
There was a problem hiding this comment.
ok you should really just use express........
this is a middleware
CptSchnitz
requested changes
Aug 19, 2025
Co-authored-by: Ofer <12687466+CptSchnitz@users.noreply.github.com>
CptSchnitz
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new metrics endpoint to provide telemetry data, enhancing the application's monitoring capabilities. Adjustments include integrating the metrics registry and updating the server response logic.