feat: fix monaco to not work cdn, latest view in connection, fix clients search + add connection dropdown MAPCO-8397

.redocly.yaml

@@ -22,7 +22,7 @@ preprocessors: {}
 rules:
   boolean-parameter-prefixes:
     severity: error
-    prefixes: ['should', 'is', 'has']
+    prefixes: ['should', 'is', 'has', 'only']
   no-unused-components:
     severity: error
   no-empty-servers: off

packages/auth-manager/openapi3.yaml

@@ -14,6 +14,11 @@ paths:
       tags:
         - client
       parameters:
+        - in: query
+          name: name
+          description: search by client name (partial match, case-insensitive)
+          schema:
+            type: string
         - in: query
           name: branch
           description: search by branch name
@@ -281,6 +286,17 @@ paths:
       tags:
         - connection
       parameters:
+        - in: query
+          name: name
+          description: search by client name (partial match, case-insensitive)
+          schema:
+            type: string
+        - in: query
+          name: onlyLatest
+          description: if true, returns only the latest version per (name, environment) pair
+          schema:
+            type: boolean
+            default: false
         - $ref: '#/components/parameters/environmentQueryParam'
         - in: query
           name: isEnabled

packages/auth-manager/package.json

@@ -52,6 +52,7 @@
     "compression": "^1.7.4",
     "config": "^3.3.9",
     "cors": "^2.8.5",
+    "date-fns": "^4.1.0",
     "express": "^4.18.2",
     "express-openapi-validator": "^5.0.3",
     "http-status-codes": "^2.2.0",

packages/auth-manager/src/client/controllers/clientController.ts

@@ -3,6 +3,7 @@ import { type Logger } from '@map-colonies/js-logger';
 import httpStatus from 'http-status-codes';
 import { injectable, inject } from 'tsyringe';
 import { IClient } from '@map-colonies/auth-core';
+import { parseISO } from 'date-fns';
 import type { TypedRequestHandlers, components, operations } from '@openapi';
 import { SERVICES } from '@common/constants';
 import { DEFAULT_PAGE_SIZE } from '@src/common/db/pagination';
@@ -20,14 +21,13 @@ function responseClientToOpenApi(client: IClient): components['schemas']['client
 }
 
 function queryParamsToSearchParams(query: NonNullable<operations['getClients']['parameters']['query']>): ClientSearchParams {
-  const { branch, tags, createdAfter, createdBefore, updatedAfter, updatedBefore } = query;
+  const { createdAfter, createdBefore, updatedAfter, updatedBefore, ...rest } = query;
   return {
-    branch,
-    tags,
-    createdAfter: createdAfter !== undefined ? new Date(createdAfter) : undefined,
-    createdBefore: createdBefore !== undefined ? new Date(createdBefore) : undefined,
-    updatedAfter: updatedAfter !== undefined ? new Date(updatedAfter) : undefined,
-    updatedBefore: updatedBefore !== undefined ? new Date(updatedBefore) : undefined,
+    ...rest,
+    createdAfter: createdAfter !== undefined ? parseISO(createdAfter) : undefined,
+    createdBefore: createdBefore !== undefined ? parseISO(createdBefore) : undefined,
+    updatedAfter: updatedAfter !== undefined ? parseISO(updatedAfter) : undefined,
+    updatedBefore: updatedBefore !== undefined ? parseISO(updatedBefore) : undefined,
   };
 }
 
@@ -51,7 +51,7 @@ export class ClientController {
   public getClients: TypedRequestHandlers['getClients'] = async (req, res, next) => {
     try {
       this.logger.debug({ msg: 'executing #getClients handler', query: req.query });
-      const searchParams = queryParamsToSearchParams(req.query as NonNullable<operations['getClients']['parameters']['query']>);
+      const searchParams = queryParamsToSearchParams(req.query ?? {});
 
       const paginationParams = {
         /* istanbul ignore next */

packages/auth-manager/src/client/models/client.ts

@@ -1,10 +1,6 @@
-import { IClient } from '@map-colonies/auth-core';
+import type { operations } from '@src/openapi';
 
-export interface ClientSearchParams {
-  branch?: IClient['branch'];
-  createdBefore?: IClient['createdAt'];
-  createdAfter?: IClient['createdAt'];
-  updatedBefore?: IClient['createdAt'];
-  updatedAfter?: IClient['createdAt'];
-  tags?: IClient['tags'];
-}
+type DateKeys = 'createdBefore' | 'createdAfter' | 'updatedBefore' | 'updatedAfter';
+
+// Converts date string query parameters to Date objects
+export type ClientSearchParams = Omit<NonNullable<operations['getClients']['parameters']['query']>, DateKeys> & { [P in DateKeys]?: Date };

packages/auth-manager/src/client/models/clientManager.ts

@@ -1,6 +1,6 @@
 import { type Logger } from '@map-colonies/js-logger';
 import { inject, injectable } from 'tsyringe';
-import { ArrayContains, QueryFailedError } from 'typeorm';
+import { ArrayContains, ILike, QueryFailedError } from 'typeorm';
 import { DatabaseError } from 'pg';
 import { Client, type IClient } from '@map-colonies/auth-core';
 import { SERVICES } from '@common/constants';
@@ -9,8 +9,8 @@ import { createDatesComparison } from '@common/db/utils';
 import { SortOptions } from '@src/common/db/sort';
 import { PaginationParams, paginationParamsToFindOptions } from '@src/common/db/pagination';
 import { type ClientRepository } from '../DAL/clientRepository';
-import { ClientSearchParams } from './client';
 import { ClientAlreadyExistsError, ClientNotFoundError } from './errors';
+import { ClientSearchParams } from './client';
 
 @injectable()
 export class ClientManager {
@@ -20,7 +20,7 @@ export class ClientManager {
   ) {}
 
   public async getClients(
-    searchParams?: ClientSearchParams,
+    searchParams: ClientSearchParams,
     paginationParams?: PaginationParams,
     sortParams?: SortOptions<Client>
   ): Promise<[IClient[], number]> {
@@ -29,17 +29,16 @@ export class ClientManager {
 
     // eslint doesn't recognize this as valid because its in the type definition
     let findOptions: Parameters<typeof this.clientRepository.find>[0] = {};
-    if (searchParams !== undefined) {
-      const { branch, tags, createdAfter, createdBefore, updatedAfter, updatedBefore } = searchParams;
-      findOptions = {
-        where: {
-          tags: tags ? ArrayContains(tags) : undefined,
-          branch,
-          createdAt: createDatesComparison(createdAfter, createdBefore),
-          updatedAt: createDatesComparison(updatedAfter, updatedBefore),
-        },
-      };
-    }
+    const { name, branch, tags, createdAfter, createdBefore, updatedAfter, updatedBefore } = searchParams;
+    findOptions = {
+      where: {
+        name: name !== undefined ? ILike(`%${name}%`) : undefined,
+        tags: tags ? ArrayContains(tags) : undefined,
+        branch,
+        createdAt: createDatesComparison(createdAfter, createdBefore),
+        updatedAt: createDatesComparison(updatedAfter, updatedBefore),
+      },
+    };
 
     if (paginationParams !== undefined) {
       findOptions = {