ci(global): done#132
Merged
Merged
Conversation
ronenkapelian
requested changes
May 4, 2026
Contributor
There was a problem hiding this comment.
-
The Chart.yaml for auth-ui is currently using appVersion for its logic, whereas our other charts have been updated to use the version field for consistency.
-
Both release-please-config.json and .release-please-manifest.json reference apps/token-ui,
The actual directory on disk is apps/kiosk-ui -
update README.md, it still documents about lerna "Before running any of the examples, you should install the dependencies and build the packages in the root of the lerna project." also on the README, its document "npm install && npx lerna run build"
-
[nitpick] - .gitignore include lerna extensions
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ronenkapelian
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.