helm: use labels and annotations package MAPCO-8094#64
Conversation
netanelC
changed the title
netanelC
changed the title
|
🎫 Related Jira Issue: MAPCO-8094 |
|
🎫 Related Jira Issue: MAPCO-8094 |
…dd-labels-and-annotations
|
🎫 Related Jira Issue: MAPCO-8094 |
…dd-labels-and-annotations
|
🎫 Related Jira Issue: MAPCO-8094 |
|
🎫 Related Jira Issue: MAPCO-8094 |
…dd-labels-and-annotations
|
🎫 Related Jira Issue: MAPCO-8094 |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Helm chart configuration to use the centralized "mc-labels-and-annotations" package for managing labels and annotations. Key changes include updating dependency declarations across charts, removing deprecated environment labels in favor of the new package, and adjusting version-bump targets to account for dependency version updates.
Reviewed Changes
Copilot reviewed 24 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/version-bump.mjs | Updated to include version targets for dependencies using hard-coded indices. |
| packages/auth-ui/helm/values.yaml | Added new mcLabelsAndAnnotations configuration and a timeout block. |
| packages/auth-ui/helm/templates/* | Removed environment label and included mc-labels-and-annotations helpers. |
| packages/auth-manager/helm/* | Similar updates to use mc-labels-and-annotations in values and templates. |
| packages/auth-cron/helm/* | Removed environment label and added mc-labels-and-annotations in templates. |
| helm/* and helm/charts/opa/* | Updated values, templates, and Chart.yaml to declare the new dependency and use it. |
Comments suppressed due to low confidence (1)
packages/auth-cron/helm/templates/cron-secret.yaml:11
- The label value concatenates '{{ $chartName }}' and 'share' without a clear separator, which may reduce clarity. Consider adding a separator (e.g., '-' or a space) to improve readability.
app: {{ $chartName }}share
| { | ||
| path: 'helm/Chart.yaml', | ||
| targets: ['version', 'dependencies[0].version', 'dependencies[1].version', 'dependencies[2].version', 'dependencies[3].version'], | ||
| }, |
There was a problem hiding this comment.
Hard-coding dependency indices in the 'targets' array may be brittle if the dependencies order changes; consider implementing a more dynamic lookup for dependency versions to improve maintainability.
Related issues: #XXX , #XXX ...
Closes #XXX ...
Further information: