feat: token generation and SSO integration MAPCO-8122 AND MAPCO-8121#79
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bootstraps the Token Kiosk service by implementing authentication, token generation, a React/Vite UI, testing configurations, and Helm deployment.
- Added Vitest and Vite configurations for unit/integration testing and UI proxy
- Implemented React UI boilerplate (
main.tsx,App.tsx) and styling - Built backend token generation, DI container, server builder, OpenAPI routes, and Helm charts
Reviewed Changes
Copilot reviewed 60 out of 67 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/token-kiosk/ui/src/App.tsx | Main React component with duplicate interface |
| packages/token-kiosk/src/containerConfig.ts | DI registration for onSignal shows nested value |
| packages/token-kiosk/tests/unit/...Manager.spec.ts | Unit tests with mismatched describe titles |
Comments suppressed due to low confidence (2)
packages/token-kiosk/tests/unit/resourceName/models/resourceNameModel.spec.ts:7
- [nitpick] The describe block title 'ResourceNameManager' does not match the tested TokenManager class; update it to 'TokenManager'.
describe('ResourceNameManager', () => {
packages/token-kiosk/tests/unit/anotherResource/models/anotherResourceManager.spec.ts:7
- [nitpick] The describe block title should match the tested AnotherResourceManager class; update it accordingly.
describe('ResourceNameManager', () => {
Comment on lines
+20
to
+34
| /** | ||
| * User information interface matching the OpenAPI schema | ||
| */ | ||
| interface UserInfo { | ||
| readonly sub: string; | ||
| readonly name?: string; | ||
| readonly givenName?: string; | ||
| readonly familyName?: string; | ||
| readonly middleName?: string; | ||
| readonly nickname?: string; | ||
| readonly preferredUsername?: string; | ||
| readonly email?: string; | ||
| readonly gender?: string; | ||
| readonly phoneNumber?: string; | ||
| } |
There was a problem hiding this comment.
The UserInfo interface is declared twice; remove the duplicate declaration to avoid confusion.
Suggested change
| /** | |
| * User information interface matching the OpenAPI schema | |
| */ | |
| interface UserInfo { | |
| readonly sub: string; | |
| readonly name?: string; | |
| readonly givenName?: string; | |
| readonly familyName?: string; | |
| readonly middleName?: string; | |
| readonly nickname?: string; | |
| readonly preferredUsername?: string; | |
| readonly email?: string; | |
| readonly gender?: string; | |
| readonly phoneNumber?: string; | |
| } | |
| // Removed duplicate UserInfo interface declaration |
Comment on lines
+41
to
+44
| useValue: { | ||
| useValue: async (): Promise<void> => { | ||
| await Promise.all([getTracing().stop()]); | ||
| }, |
There was a problem hiding this comment.
The provider for 'onSignal' has a nested useValue property, causing confusion in DI registration; it should directly supply the function without the extra useValue wrapper.
Suggested change
| useValue: { | |
| useValue: async (): Promise<void> => { | |
| await Promise.all([getTracing().stop()]); | |
| }, | |
| useValue: async (): Promise<void> => { | |
| await Promise.all([getTracing().stop()]); |
CptSchnitz
changed the title
|
🎫 Related Jira Issue: MAPCO-8122 |
netanelC
approved these changes
Jul 3, 2025
Contributor
netanelC
left a comment
netanelC
left a comment
There was a problem hiding this comment.
I didn't review tests and ui folders
|
|
||
| export type TokenResponse = components['schemas']['tokenResponse']; | ||
|
|
||
| export type TokenCache = Cache & { |
Contributor
There was a problem hiding this comment.
Suggested change
| export type TokenCache = Cache & { | |
| type TokenCache = Cache & { |
| import type { components as authManagerComponents } from '@src/auth-manager'; | ||
| import type { AuthManagerClient } from './authManagerClient'; | ||
|
|
||
| export type TokenResponse = components['schemas']['tokenResponse']; |
Contributor
There was a problem hiding this comment.
Suggested change
| export type TokenResponse = components['schemas']['tokenResponse']; | |
| type TokenResponse = components['schemas']['tokenResponse']; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented so far:
not implemented: