Skip to content

feat: add tile deletion schemas and types, refactor source type#191

Merged
almog8k merged 4 commits into
alphafrom
feat/tiles-deletion
May 4, 2026
Merged

feat: add tile deletion schemas and types, refactor source type#191
almog8k merged 4 commits into
alphafrom
feat/tiles-deletion

Conversation

@almog8k
Copy link
Copy Markdown
Collaborator

@almog8k almog8k commented May 4, 2026

Question Answer
New feature

Further information:

This pull request introduces new tile deletion parameter schemas and types, and refactors the SourceType constant and type to the core constants module for better consistency and reuse. The main changes focus on schema validation for tile deletion operations and code organization.

Schema and Type Additions:

  • Added tileRangeSchema, tilesDeletionParamsBaseSchema, and provider-specific schemas (s3TilesDeletionParamsSchema, fsTilesDeletionParamsSchema) using zod for validating tile deletion parameters in src/schemas/core/tile.schema.ts.
  • Introduced TypeScript types TilesDeletionParams and TileRange inferred from the new schemas in src/types/core/tile.type.ts.

Constants Refactoring:

  • Moved the SourceType constant and type definition from src/constants/export/constants.ts to src/constants/core/constants.ts for centralized usage and maintainability [1] [2].
  • Added MAX_ZOOM_LEVEL constant to src/constants/core/constants.ts for use in tile validation.

Co-authored-by: Copilot <copilot@github.com>
Copy link
Copy Markdown
Contributor

@razbroc razbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know what you think

Comment thread src/schemas/core/tile.schema.ts
Comment thread src/schemas/core/tile.schema.ts Outdated
Comment thread src/schemas/core/tile.schema.ts Outdated
Comment thread src/schemas/core/tile.schema.ts Outdated
almog8k and others added 3 commits May 4, 2026 16:07
Co-authored-by: razbroc <77406876+razbroc@users.noreply.github.com>
Co-authored-by: razbroc <77406876+razbroc@users.noreply.github.com>
Co-authored-by: razbroc <77406876+razbroc@users.noreply.github.com>
@almog8k almog8k requested a review from razbroc May 4, 2026 13:11
Copy link
Copy Markdown
Contributor

@razbroc razbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much for your service!!!

@almog8k almog8k merged commit c87c428 into alpha May 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants