Conversation
| classDef head fill:#5882FA | ||
| classDef workflow fill:#1E4E20 | ||
| A[Build And Push Docker]:::head --> B[Checkout latest commit] | ||
| B --> C(Login to Azure) |
| classDef workflow fill:#1E4E20 | ||
| A[Build And Push Docker]:::head --> B[Checkout latest commit] | ||
| B --> C(Login to Azure) | ||
| C --> D(Get Docker Image Name) |
There was a problem hiding this comment.
It's not "get" as much as "generate"
| classDef workflow fill:#1E4E20 | ||
| A[Build And Push Helm]:::head --> B[Checkout latest commit] | ||
| B --> C[Setup Helm] | ||
| C --> D[Login to Azure] |
| D --> E(Get Chart Name) | ||
| E --> F[Get Chart Version] |
There was a problem hiding this comment.
Retrieving chart name,
Retrieving chart version
| C --> D(Get Docker Image Name) | ||
| D --> E( Build Image) | ||
| E --> F[Push Image] | ||
| G[workflow: Edit artifacts.json in helm-charts]:::workflow |
There was a problem hiding this comment.
I believe there should be an arrow to the "edit artifacts.json" workflow, so the reference would be more clear
| E --> F[Get Chart Version] | ||
| F --> G[Package Chart into TGZ] | ||
| G --> H[Publish Chart to ACR] | ||
| I[workflow: Edit artifacts.json in helm-charts]:::workflow |
There was a problem hiding this comment.
I believe there should be an arrow to the "edit artifacts.json" workflow, so the reference would be more clear
| D --> E[Set up Node.js] | ||
| E --> F[Install dependencies] | ||
| F --> G[Run linters] | ||
| G -->|enableOpenApiCheck==true| H["OpenAPI Lint Checks \n (on `openApiFilePath`)"] |
There was a problem hiding this comment.
"OpenAPI Lint Checks \n (on openApiFilePath)"
I think Lint checks on OpenAPI file should be good here
There was a problem hiding this comment.
Changed, although I'm not seeing a big difference
| ```mermaid | ||
| flowchart TD | ||
| classDef head fill:#5882FA | ||
| A[Release On Tag Push]:::head -->|INPUTS: \n enableOpenApiToPostman| C["Checkout code for CHANGELOG.md \n (for release notes)"] |
There was a problem hiding this comment.
Checkout Git repository is more precise
| F --> G[Package Chart into TGZ] | ||
| G --> H[Publish Chart to ACR] | ||
| I[workflow: Edit artifacts.json in helm-charts]:::workflow | ||
| A --> I[workflow: Edit artifacts.json in helm-charts]:::workflow |
There was a problem hiding this comment.
Change to Trigger update-artifacts-file workflow.
Plus, arrow should come from step H, since it would be triggerd only if first job is completed.
| C --> D(Generate Docker Image Name) | ||
| D --> E( Build Image) | ||
| E --> F[Push Image] | ||
| A --> G[workflow: Edit artifacts.json in helm-charts]:::workflow |
There was a problem hiding this comment.
Change to "Trigger update-artifacts-file workflow".
Plus, arrow should come from step E, since it would be triggerd only if first job is completed.
2 participants
This PR adds a diagram (using mermaid) to every workflow