Skip to content

feat(infra): change helm and docker path to include scope #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalby24 merged 2 commits into from
Jan 7, 2025
Merged

feat(infra): change helm and docker path to include scope #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86b7727
feat(infra): change docker image path
Jan 6, 2025
58d1d0d
feat(infra): change helm path to include scope
Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-and-push-docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_call:
inputs:
scope:
required: false
required: true
type: string
default: ""
repository:
Expand Down Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Setup docker image name and downcase it
run: |
if [[ -z "${{ inputs.repository }}" ]]; then
export DOCKER_IMAGE_NAME="${{ secrets.ACR_URL }}/${{ github.event.repository.name }}:${{ github.ref_name }}"
export DOCKER_IMAGE_NAME="${{ secrets.ACR_URL }}/${{ inputs.scope }}/${{ github.event.repository.name }}:${{ github.ref_name }}"
else
export DOCKER_IMAGE_NAME="${{ secrets.ACR_URL }}/${{ inputs.repository }}:${{ github.ref_name }}"
fi
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-and-push-helm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_call:
inputs:
scope:
required: false
required: true
type: string
default: ""

Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:

- name: Publish chart to ACR
run: |
helm push ${{ steps.set-chart-name.outputs.chart }}-${{ steps.set-chart-version.outputs.ver }}.tgz oci://${{ secrets.ACR_URL }}/helm
helm push ${{ steps.set-chart-name.outputs.chart }}-${{ steps.set-chart-version.outputs.ver }}.tgz oci://${{ secrets.ACR_URL }}/helm/${{ inputs.scope }}
working-directory: ./helm

update-helm-artifact-yaml:
Expand Down