feat: parse Obstacle GeoJSON from third-party (MAPCO-10524)#29
Merged
Conversation
- buildLayerQuery: new selection set matching Obstacle/DisplayInObstacle/Identifiers schema
- geometryParser: maps geography.coordinates + graphicsObjectKind to Point/LineString/Polygon
- layersClient: filters deleted=true and maps raw obstacles to {id, geom, properties}
- adds unit tests covering happy + error cases
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🎫 Related Jira Issue: MAPCO-10524 |
asafmas-rnd
requested changes
May 20, 2026
| import { buildLayerQuery } from '../layersClientModel'; | ||
| import { geographyToGeoJSON, type RawGeography } from './geometryParser'; | ||
|
|
||
| interface RawLayerObject { |
Contributor
There was a problem hiding this comment.
Why is it not defined in "types/thirdParty"?
Comment on lines
+6
to
+7
| createdBy | ||
| creationTime |
Contributor
There was a problem hiding this comment.
Do we need to query it?
| createdBy | ||
| creationTime | ||
| deleted | ||
| entityVersion |
Contributor
There was a problem hiding this comment.
Do we need to query it?
Check all fields with the product
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: #XXX , #XXX ...
Closes #XXX ...
Further information:
https://mapcolonies.atlassian.net/browse/MAPCO-10524