Skip to content

fix: improve jazzy build compatibility#358

Merged
rsasaki0109 merged 2 commits intoMapIV:develop-ros2from
rsasaki0109:fix/jazzy-build-compat
Mar 26, 2026
Merged

fix: improve jazzy build compatibility#358
rsasaki0109 merged 2 commits intoMapIV:develop-ros2from
rsasaki0109:fix/jazzy-build-compat

Conversation

@rsasaki0109
Copy link
Copy Markdown
Collaborator

Summary

  • fix GeographicLib lookup and export for newer environments
  • link yaml-cpp explicitly where YAML::LoadFile is used
  • update tf2 sensor/eigen header includes for Jazzy-compatible builds
  • add missing package dependencies used at build or launch time

Details

  • eagleye_coordinate
    • switch GeographicLib linking to find_library()
    • export ament_index_cpp
    • export GeographicLib include path for downstream consumers
  • eagleye_navigation
    • link yaml-cpp
  • eagleye_rt
    • link yaml-cpp for nodes that load YAML directly
    • add eagleye_tf dependency
    • update tf2_sensor_msgs and tf2_eigen includes to .hpp
  • eagleye_geo_pose_fusion
    • add missing ament_index_cpp dependency

Validation

  • colcon build --packages-up-to eagleye_navigation --cmake-args -DCMAKE_BUILD_TYPE=Release
  • colcon build --packages-select eagleye_rt --cmake-args -DCMAKE_BUILD_TYPE=Release
  • colcon build --packages-skip eagleye_gnss_converter --cmake-args -DCMAKE_BUILD_TYPE=Release

Notes

  • I intentionally did not include the local eagleye_config.yaml parameter tuning in this PR.
  • Full workspace build is still blocked in my current non-root test environment by eagleye_gnss_converter pulling a system GeographicLib path via external package dependencies.

Copy link
Copy Markdown

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

)

ament_auto_find_build_dependencies()
target_link_libraries(eagleye_navigation yaml-cpp)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're removing the second ament_auto_find_build_dependencies() call on line 55 and replacing it with just the yaml-cpp linking. This might cause issues if there were other dependencies being found by this call. Consider keeping both lines:

Suggested change
target_link_libraries(eagleye_navigation yaml-cpp)
ament_auto_find_build_dependencies()
target_link_libraries(eagleye_navigation yaml-cpp)

@rsasaki0109
Copy link
Copy Markdown
Collaborator Author

Additional validation on 2026-03-26:

  • reran the workspace build in a root-enabled ROS 2 Jazzy environment
  • confirmed full workspace build passes, including eagleye_gnss_converter and eagleye_rt
  • the earlier eagleye_gnss_converter failure was caused by missing system GeographicLib installation in my non-root test setup, not by this patch set

@rsasaki0109 rsasaki0109 merged commit 28193d7 into MapIV:develop-ros2 Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant