fix: improve jazzy build compatibility#358
Merged
rsasaki0109 merged 2 commits intoMapIV:develop-ros2from Mar 26, 2026
Merged
Conversation
| ) | ||
|
|
||
| ament_auto_find_build_dependencies() | ||
| target_link_libraries(eagleye_navigation yaml-cpp) |
There was a problem hiding this comment.
You're removing the second ament_auto_find_build_dependencies() call on line 55 and replacing it with just the yaml-cpp linking. This might cause issues if there were other dependencies being found by this call. Consider keeping both lines:
Suggested change
| target_link_libraries(eagleye_navigation yaml-cpp) | |
| ament_auto_find_build_dependencies() | |
| target_link_libraries(eagleye_navigation yaml-cpp) |
Collaborator
Author
|
Additional validation on 2026-03-26:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yaml-cppexplicitly whereYAML::LoadFileis usedDetails
eagleye_coordinatefind_library()ament_index_cppeagleye_navigationyaml-cppeagleye_rtyaml-cppfor nodes that load YAML directlyeagleye_tfdependencytf2_sensor_msgsandtf2_eigenincludes to.hppeagleye_geo_pose_fusionament_index_cppdependencyValidation
colcon build --packages-up-to eagleye_navigation --cmake-args -DCMAKE_BUILD_TYPE=Releasecolcon build --packages-select eagleye_rt --cmake-args -DCMAKE_BUILD_TYPE=Releasecolcon build --packages-skip eagleye_gnss_converter --cmake-args -DCMAKE_BUILD_TYPE=ReleaseNotes
eagleye_config.yamlparameter tuning in this PR.eagleye_gnss_converterpulling a system GeographicLib path via external package dependencies.