Skip to content

Conversation

@ppaul12
Copy link
Contributor

@ppaul12 ppaul12 commented Apr 7, 2023

  • changed main.py to pose_main.py
  • changed config/evaluation.yml to config/evaluation_pose.yml
  • added scripts for eagleye evaluation to sub_scripts
  • added scripts for twist evaluation as twist_main.py

@ppaul12 ppaul12 requested review from KOKIAOKI and rsasaki0109 April 7, 2023 06:36
@rsasaki0109
Copy link

rsasaki0109 commented Apr 10, 2023

I have tested the functionality of scripts/twist_main.py and sub_scripts/sub_eagleye_evaluation.py, and they seem to be working without any issues.

@KOKIAOKI
Copy link
Contributor

KOKIAOKI commented Apr 14, 2023

Add Releases

Release number will be 1.0.0 in this commit
Add Release tag
Follow the Release number rule since this commit.

Remove following files and folders because they don't seem to be used

config/adjust_time_stamp.yaml
sample_data/adjust_time_test_data
sample_data/config/adjust_time_stamp.yaml

sub_scripts/develop/
sub_scripts/adjust_time_stamp.py

Remove adjust_time_stamp item in README

Simplify README

title
summary
Main: Compare multiple localization results. CSV file and ros2 bag file are available. Eagleye: Eagleye evaluation.
Sub: Evaluation with localization performance in Autoware.

1.Installation
2.Main Evaluation (pose_main.py)

  • pose_main.py
  • twist_main.py

3.Sub Evaluation (second README file)
A. NDT performance in Autoware NDT (Evaluate TP, NVTL, execution time, iteration and error ellipse with ros2 bag files)
B. sub eagleye evaluation
C. Create CSV file with covariance column from ros1 bag file
4.Test run (click open)
test command (Please fix)
graphs

Detail explanation should be hided with click button

Add explanation

twist.yaml

Others

Save graphs before displaying graphs
Revise “TF” to “Adjustment”
If you have a time,

  • simplify yaml setting by using array
  • add another topic in ros2bag input. e.g. geometry_msgs/PoseStamped (Future task)

@KOKIAOKI
Copy link
Contributor

KOKIAOKI commented Apr 14, 2023

My suggestion of new yaml format
evaluation_pose.txt

Copy link
Contributor

@KOKIAOKI KOKIAOKI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additional fix.

@KOKIAOKI KOKIAOKI merged commit b54b286 into MapIV:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants