Skip to content

Add a new padding template format option#5890

Merged
rouault merged 7 commits intoMapServer:masterfrom
geographika:template-padding
Oct 9, 2019
Merged

Add a new padding template format option#5890
rouault merged 7 commits intoMapServer:masterfrom
geographika:template-padding

Conversation

@geographika
Copy link
Copy Markdown
Member

See #5889 - adds a new "padding" format option for fixed length strings in a template.

Online testing in REPL at https://repl.it/repls/LeftSlimQuotient
Reviews of C code welcome, especially if variable declarations should be moved, and everything is created and freed correctly.

Copy link
Copy Markdown
Contributor

@rouault rouault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to extend (or create) a msautotest for this

@geographika
Copy link
Copy Markdown
Member Author

@rouault - many thanks for the review and explanations. I'll try and find an autotest for templates to add this to (also I'll update docs if this pull request is accepted).

@sdlime
Copy link
Copy Markdown
Member

sdlime commented Oct 4, 2019 via email

@geographika
Copy link
Copy Markdown
Member Author

@sdlime - the main use case is to allow for creation of RST tables which rely on fixed width strings. I've no current use case for left padding though.
I've added docs and the RST table example to MapServer/MapServer-documentation#286
@rouault - thanks for taking the time to explain the errors. I think this is my first non-Python MapServer "feature" :)

@rouault
Copy link
Copy Markdown
Contributor

rouault commented Oct 4, 2019

@rouault - thanks for taking the time to explain the errors. I think this is my first non-Python MapServer "feature" :)

Champaign !

@rouault rouault merged commit 84e0ce8 into MapServer:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants