Skip to content

Make numlabels and labelLeaderObj immutable#5929

Merged
geographika merged 2 commits intoMapServer:masterfrom
geographika:classObj-properties
Nov 26, 2019
Merged

Make numlabels and labelLeaderObj immutable#5929
geographika merged 2 commits intoMapServer:masterfrom
geographika:classObj-properties

Conversation

@geographika
Copy link
Copy Markdown
Member

See comments at #5870 (comment)

Numlabels - or any similar counters - should be immutable. So following that logic numstyles should also be immutable.
Leader - no so sure about that one. Looks like styles and labels aren't even exposed to MapScript and users must work through the helper methods. Makes sense since they are arrays. 

@geographika geographika merged commit 5a06fc8 into MapServer:master Nov 26, 2019
geographika added a commit to geographika/mapserver that referenced this pull request Nov 26, 2019
… due to line ending changes

This reverts commit 5a06fc8.
This was referenced Nov 26, 2019
rouault added a commit that referenced this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant