Process empty path requests with mapfiles in querystrings#7366
Merged
Conversation
Member
|
thanks @geographika. Can you possibly include an msautotest for this? (I imagine there should be a way to call this through localhost and check the response with curl etc). thanks again. |
Member
Author
|
@jmckenna - tests added. It was possible to recreate using msautotests. |
Member
|
thanks @geographika ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the latest
mainbranch in a few different environments, I noticed requests using the newMS_INDEX_TEMPLATE_DIRECTORYwould return the index page for requests withPATH_INFOset to/but with a valid querystring containing a map e.g.http://localhost:7000/?map=/etc/mapserver/lines.map&REQUEST=GetMap....This PR should ensure the index page is only returned when no map is loaded, or no parameters are passed to MapServer.