Add redis cache (ported to new codebase) #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Contains updated CMake file with option to configure using hiredis official C redis library. * Contains update configuration parse and mapcache.h file to add support for redis cache. * Add lib/cache_redis.c file with preliminary redis support.
* In cmake/FindRedis.cmake remove duplicate lines.
* Add an example redis config the XML config sample file.
* Move expiration time before data segment in SETEX call.
* Use correct error-handling as specified in the strtoul manpages.
jbo-ads
reviewed
Aug 31, 2021
Member
jbo-ads
left a comment
jbo-ads
left a comment
There was a problem hiding this comment.
Thank you for submitting this new feature!
Here are my few comments on your code. I didn't check the actual logic of redis management. I hope your tests will detect any misbehaviours.
Contributor
Author
regarding tests performed, it works fine for me from mapcache_seed and from running as apache module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored code from (#116) still did not test all features but it should work if old code was working.
Will test it a bit more from real system and report back in this PR