fix: avoid FOSSA SciPy 1.11.0 license hit#26
Conversation
|
Thank you for raising your pull request and contributing to voscript. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 77.59% 77.59%
=======================================
Files 75 75
Lines 2906 2906
=======================================
Hits 2255 2255
Misses 651 651
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
❤️ Great PR @MapleEve ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the runtime dependency constraints to avoid a license-scanner (FOSSA) hit specific to SciPy 1.11.0’s sdist, by moving the minimum SciPy version to a later patch release and documenting the rationale inline in the requirements file.
Changes:
- Raise the SciPy lower bound from
>=1.11.0to>=1.11.4. - Add an explanatory comment documenting why SciPy 1.11.0 is avoided.
- Introduce a SciPy upper bound to keep installs on the 1.11.x line.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Stay on SciPy 1.11.x to avoid dependency/license drift while avoiding the | ||
| # 1.11.0 sdist GPL-hit file: scipy/_lib/unuran/unuran/src/specfunct/log1p.c. | ||
| scipy>=1.11.4,<1.12.0 |
Summary
>=1.11.0to>=1.11.4.1.11.0is avoided: the SciPy 1.11.0 sdist contains the vendored UNU.RAN GPL-2.0-or-later hit atscipy/_lib/unuran/unuran/src/specfunct/log1p.c.FOSSA context
1.11.0contains the flagged vendored UNU.RAN file.1.11.4+no longer contains that exact flagged file in the checked sdist versions.Validation
python3requirements smoke check: confirmedscipy>=1.11.4, noscipy>=1.11.0, and note present.git diff --checkpython3 -m pip install --dry-run --ignore-installed --only-binary=:all: "numpy>=1.24.0,<2.0" "scipy>=1.11.4"resolved tonumpy-1.26.4 scipy-1.17.1.scipy 1.11.0containsscipy/_lib/unuran/unuran/src/specfunct/log1p.c;scipy 1.11.4andscipy 1.17.1do not.Follow-up