Upgrade playwright, grunt-html #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass at migrating away from jest. Tests to be migrated one
by one, in a draft PR, just like the ants.
Add package.json, package-lock.json, jest.config.js,
jest-playwright.config.js to commit, which were missed in last
commit for some reason
Migrate announceMovement.test.js to playwright test
Migrate axisInferring.test.js to playwright test
Migrate drag.test.js to playwright test, restore e2e/data directory
Migrate featureIndexOverlay.test.js to playwright test
Migrate featureLinks.test.js to playwright test
Migrate fullscreenControl.test.js to playwright test
Migrate history.test.js to playwright test
Migrate layerAttributes.test.js to playwright test. There was a
flaky path that would not respond to hover.
Migrate layerContextMenu.test.js to playwright test. Playwright
no longer would automatically right click a disabled layer. Added
{ button: "right", force: true } option, seems to work now.
Migrate linkTypes.test.js to playwright test.
Migrate mapElement.test.js, mapContextMenu.test.js to playwright test.
Migrate mapSpan.test.js to playwright test. Had to add a timeout
Migrate metaDefault.test.js to playwright test. Had to add a timeout
Migrate mismatchedLayerWithMap.test.js to playwright test. Unsure
how to goto a blank page that is editable, so I had to create
empty.html and go to that. Had to add a
{ button: "right", force: true } to get the right button click to
work again.
Migrate missingMetaParameters.test.js to playwright test.
Work in progress on popupNavigation.test.js
Migrate popupTabNavigation.test.js to playwright test
Migrate projectionChange.test.js to playwright test
Remove path from devDependencies (what was it for?)
Migrate reticle.test.js to playwright test
Migrate styleParsing.test.js to playwright test
Migrate scroll.test.js to playwright test
Migrate tabFeatureNavigation.test.js to playwright test
Migrate tms.test.js to playwright test
Migrate zoomChangeProjection.test.js to playwright test
Migrate clientTemplatedTileLayer.test.js to playwright test
Migrate mapMLLayerControl.test.js to playwright test
Migrate multipleExtents.test.js to playwright test
Migrate multipleQueryExtents.test.js to playwright test
Migrate queryLink.test.js to playwright test
Split multipleQueryExtents.test.js into multipleHeterogenousQueryExtents
to improve parallelism
Try to improve speed of drag.test.js without breaking it
Migrate customTCRS.test.js to playwright test
Migrate mapml-viewer.test.js to playwright test
Migrate viewerContextMenu.test.js to playwright test
Restore jest for unit tests, add jest execution to gh action
Tweak multipleHeterogeneousQueryExtents.test.js, which is still a bit
fragile
Restore more of jest for unit tests, fix the ci-testing invocation of it.
Migrate layers/mapMLFeatures.test.js, layers/mapMLStaticTileLayer.test.js,
layers/mapMLTemplatedFeatures.test.js, layers/mapMLTemplatedFeaturesFilter.test.js,
layers/mapMLTemplatedImageLayer.test.js, layers/mapMLTemplatedTileLayer.test.js
to playwright test, along shared tests layers/general/*.js, which are
imported into each of the above tests and executed as parameterized
tests.
Migrate step/*.test.js to playwright test
Add package-lock.json in the vain hope it will quit changing
prushforth
force-pushed
the
upgrade-playwright
branch
from
e062d84 to
6eec735
Compare
prushforth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ben-lu-uw @bershanskiy I'm going to chip away at this problem by migrating tests one by one to playwright-test. Please let me know if you see improvements in code / code style that I may have overlooked due to cargo cult copying. Thank you 🙏
Closes #608