-
Notifications
You must be signed in to change notification settings - Fork 9
Upgrade SDK and Mapbox versions #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes update the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
packages/map-template/package.json(1 hunks)packages/map-template/src/components/MapTemplate/MapTemplate.jsx(1 hunks)
🔇 Additional comments (1)
packages/map-template/package.json (1)
28-30: Confirm Mapbox-GL 3.8.0 compatibility and bundle size impact
mapbox-gljumped from 3.5.2 → 3.8.0. 3.7 introduced ESM-only builds and removed support for some legacy style spec members.
Please double-check:
- Any dynamic
require()or CommonJS stubs in the codebase (or in MapsIndoors SDK 4.41.x) – they will break on pure-ESM.- Changes to
Mapconstructor options (e.g.optimizeForTerrain,fog) that could affect runtime behaviour.- Bundle size regressions → run
vite build --reportbefore publishing.If everything works, no further action. Otherwise lock to
~3.6or add a compatibility shim.
ammapspeople
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Summary by CodeRabbit