Conversation
Contributor
📝 WalkthroughWalkthroughUpdated the MapsIndoors JavaScript SDK reference from 4.49.0 to 4.49.1 in the MapTemplate dynamic loader and added a changelog entry (version 1.91.5) documenting the Web SDK update. Changes
Sequence Diagram(s)(omitted — changes are small and do not introduce new multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ing a fix for the Web SDK version.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/map-template/src/components/MapTemplate/MapTemplate.jsx`:
- Around line 238-239: The integrity attribute used when creating the
MapsIndoors SDK script tag is incorrect and causes browsers to reject the
resource; update the call that sets the integrity on miSdkApiTag (see
miSdkApiTag.setAttribute('integrity', ...)) to use the correct SRI value
"sha384-AgZdUiaUaOcGFaV4SsCcMecYmDg21p3YCodPeBJujrfIpm6+sexCHkzdXhc5g2Aa" so the
loaded SDK matches its published artifact.
Comment on lines
+238
to
+239
| miSdkApiTag.setAttribute('src', 'https://app.mapsindoors.com/mapsindoors/js/sdk/4.49.1/mapsindoors-4.49.1.js.gz'); | ||
| miSdkApiTag.setAttribute('integrity', 'sha384-Yt+gfsWoPoSA+odTtvTDJaQK8tsiKgVmTQt4AwN4TlYcRtZS89BowiE8Ycgzbhlm'); |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the SRI hash for the MapsIndoors SDK 4.49.1
EXPECTED_HASH="sha384-Yt+gfsWoPoSA+odTtvTDJaQK8tsiKgVmTQt4AwN4TlYcRtZS89BowiE8Ycgzbhlm"
# Download the SDK file
curl -sL -o /tmp/mapsindoors-sdk.js.gz "https://app.mapsindoors.com/mapsindoors/js/sdk/4.49.1/mapsindoors-4.49.1.js.gz"
# Check if download succeeded
if [ ! -s /tmp/mapsindoors-sdk.js.gz ]; then
echo "ERROR: Failed to download SDK file or file is empty"
exit 1
fi
# Compute SRI hash
COMPUTED_HASH="sha384-$(openssl dgst -sha384 -binary /tmp/mapsindoors-sdk.js.gz | openssl base64 -A)"
echo "Expected: $EXPECTED_HASH"
echo "Computed: $COMPUTED_HASH"
if [ "$EXPECTED_HASH" = "$COMPUTED_HASH" ]; then
echo "✅ SRI hash matches!"
else
echo "❌ SRI hash DOES NOT match!"
fiRepository: MapsPeople/web-ui
Length of output: 300
🏁 Script executed:
#!/bin/bash
python3 << 'EOF'
import hashlib
import base64
import urllib.request
EXPECTED_HASH = "sha384-Yt+gfsWoPoSA+odTtvTDJaQK8tsiKgVmTQt4AwN4TlYcRtZS89BowiE8Ycgzbhlm"
SDK_URL = "https://app.mapsindoors.com/mapsindoors/js/sdk/4.49.1/mapsindoors-4.49.1.js.gz"
try:
# Download the SDK file
with urllib.request.urlopen(SDK_URL) as response:
sdk_data = response.read()
if not sdk_data:
print("ERROR: Failed to download SDK file or file is empty")
exit(1)
# Compute SHA-384 hash
sha384_hash = hashlib.sha384(sdk_data).digest()
computed_base64 = base64.b64encode(sha384_hash).decode('utf-8')
computed_hash = f"sha384-{computed_base64}"
print(f"Expected: {EXPECTED_HASH}")
print(f"Computed: {computed_hash}")
if EXPECTED_HASH == computed_hash:
print("✅ SRI hash MATCHES!")
else:
print("❌ SRI hash DOES NOT match!")
except Exception as e:
print(f"ERROR: {e}")
exit(1)
EOFRepository: MapsPeople/web-ui
Length of output: 195
🏁 Script executed:
#!/bin/bash
python3 << 'EOF'
import hashlib
import base64
import urllib.request
import ssl
EXPECTED_HASH = "sha384-Yt+gfsWoPoSA+odTtvTDJaQK8tsiKgVmTQt4AwN4TlYcRtZS89BowiE8Ycgzbhlm"
SDK_URL = "https://app.mapsindoors.com/mapsindoors/js/sdk/4.49.1/mapsindoors-4.49.1.js.gz"
try:
# Disable SSL verification for sandbox environment
ssl_context = ssl._create_unverified_context()
# Download the SDK file
with urllib.request.urlopen(SDK_URL, context=ssl_context) as response:
sdk_data = response.read()
if not sdk_data:
print("ERROR: Failed to download SDK file or file is empty")
exit(1)
# Compute SHA-384 hash
sha384_hash = hashlib.sha384(sdk_data).digest()
computed_base64 = base64.b64encode(sha384_hash).decode('utf-8')
computed_hash = f"sha384-{computed_base64}"
print(f"Expected: {EXPECTED_HASH}")
print(f"Computed: {computed_hash}")
print(f"File size: {len(sdk_data)} bytes")
if EXPECTED_HASH == computed_hash:
print("✅ SRI hash MATCHES!")
else:
print("❌ SRI hash DOES NOT match!")
except Exception as e:
print(f"ERROR: {e}")
import traceback
traceback.print_exc()
exit(1)
EOFRepository: MapsPeople/web-ui
Length of output: 277
Update the SRI integrity hash to match the published SDK artifact.
The integrity hash in the code does not match the actual published SDK file. The hash sha384-Yt+gfsWoPoSA+odTtvTDJaQK8tsiKgVmTQt4AwN4TlYcRtZS89BowiE8Ycgzbhlm is incorrect. Browsers will reject the SDK load due to failed integrity verification. Update line 239 to use the correct hash: sha384-AgZdUiaUaOcGFaV4SsCcMecYmDg21p3YCodPeBJujrfIpm6+sexCHkzdXhc5g2Aa
🤖 Prompt for AI Agents
In `@packages/map-template/src/components/MapTemplate/MapTemplate.jsx` around
lines 238 - 239, The integrity attribute used when creating the MapsIndoors SDK
script tag is incorrect and causes browsers to reject the resource; update the
call that sets the integrity on miSdkApiTag (see
miSdkApiTag.setAttribute('integrity', ...)) to use the correct SRI value
"sha384-AgZdUiaUaOcGFaV4SsCcMecYmDg21p3YCodPeBJujrfIpm6+sexCHkzdXhc5g2Aa" so the
loaded SDK matches its published artifact.
…e demo-office monorepo package and an update to the Web SDK version.
Lucaci-Andrei
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit