improvement(a11y): toggle iframe tabindex on card flip (MP-204) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Subscribe iframe now becomes focusable (tabindex=0) when card is flipped - Iframe is unfocusable (tabindex=-1) when card is in normal state - Ensures keyboard users can interact with LoopAware subscribe form - Added Playwright assertions to verify tabindex toggle behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tabindex="-1"always, making iframe unfocusabletabindex="0"when card is flipped,tabindex="-1"when unflippedChanges
script.js: UpdatedtoggleFliphandler to toggle iframe tabindextests/hero.spec.js: Added assertions verifying tabindex toggle behaviorTest plan
npx playwright test— all 7 tests passnpx eslint script.js tests/*.js mpr-band.js— no violationstabindex="-1"before fliptabindex="0"after fliptabindex="-1"after unflip🤖 Generated with Claude Code