Conversation
This commit adds unit testing for LoginViewModel. This commit also moves the coroutine from the View to the ViewModel, but using `viewModelScope` in place of `rememberCoroutineScope`.
| coroutine.launch { | ||
| viewModel.pressButton() | ||
|
|
||
| } |
There was a problem hiding this comment.
rememberCoroutineScope totally works, but in this case, it is a bit more normal to use viewModelScope.launch in the ViewModel instead of doing the coroutine in the view.
|
|
||
| } | ||
|
|
||
| @VisibleForTesting fun isValidEmail(email: String): Boolean = Patterns.EMAIL_ADDRESS.matcher(email).matches() |
There was a problem hiding this comment.
@VisibleForTesting is cool (to me 🤓). Basically, this function should be private. But if it was private, you couldn't test it in LoginViewModelTest. So @VisibleForTesting lets you use it in your test, but if you try to use this function anywhere else you will have problems compiling the app.
| } | ||
|
|
||
| @VisibleForTesting fun isValidEmail(email: String): Boolean = Patterns.EMAIL_ADDRESS.matcher(email).matches() | ||
| @VisibleForTesting fun isValidPassword(password: String): Boolean = password.length > 6 |
There was a problem hiding this comment.
Suggestion: you could make "6" here a constant, and then it would make unit testing whether isValidPassword is working easier 🤔
Maria1-eng
left a comment
Maria1-eng
left a comment
There was a problem hiding this comment.
Regarding the tests, why should I use that runner? Is it especially useful for this case? I’ve read that it’s very fast. I'd like to know more about that
|
That is a very good question 👏 I had to use it because the tests were not working without it. The reason they weren't working is that, in order to determine if an e-mail was valid or not, you wrote this Basically, my understanding is that you need to use Roboelectric if you use code that uses things that are really specific to "Android" and not just "Kotlin" or "Java". If you didn't use Roboelectric, then, from what I know, you would have to run these tests on an emulator, and that is what it means by being "very fast" - because it would be really slow to boot up an emulator every time you wanted to run tests. https://developer.android.com/training/testing/local-tests/robolectric I think you are on your way to knowing a lot more about this than I do 😆 |
2 participants
This commit adds unit testing for LoginViewModel.
This commit also moves the coroutine from the View to the ViewModel, but using
viewModelScopein place ofrememberCoroutineScope.Screen.Recording.2025-11-03.at.8.03.42.PM.mov