MDBF-1186: NGINX CI for Connectors#915
MDBF-1186: NGINX CI for Connectors#915RazvanLiviuVarzaru wants to merge 1 commit intoMariaDB:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Defines NGINX locations for where Buildbot publishes connector artifacts in CI.
Changes:
- Add NGINX
locationblocks for ODBC, C, and C++ connector artifact paths - Map connector URL prefixes to filesystem directories under
/srv/buildbot/connectors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Define the locations where the connectors artifacts are published by Buildbot builds
9094385 to
02a163d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -34,6 +34,18 @@ server { | |||
| autoindex off; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
location /connector-odbc/ will not match requests to /connector-odbc (without the trailing slash), which will likely fall through to the server root and 404. Consider adding an exact-match redirect (location = /connector-odbc { return 301 /connector-odbc/; }) or changing the prefix location to /connector-odbc to match both forms.
| location = /connector-odbc { | |
| return 301 /connector-odbc/; | |
| } |
| location /connector-odbc/ { | ||
| alias /srv/buildbot/connectors/odbc/; | ||
| } | ||
|
|
There was a problem hiding this comment.
location /connector-cpp/ will not match /connector-cpp (no trailing slash), so that common URL will fall back to the server root and likely 404. Add an exact-match redirect to the slash form or remove the trailing slash from the location prefix to accept both.
| location = /connector-cpp { | |
| return 301 /connector-cpp/; | |
| } |
Define the locations where the connectors artifacts are published by Buildbot builds