Skip to content

MDBF-1186: NGINX CI for Connectors#915

Open
RazvanLiviuVarzaru wants to merge 1 commit intoMariaDB:devfrom
RazvanLiviuVarzaru:MDBF-1186
Open

MDBF-1186: NGINX CI for Connectors#915
RazvanLiviuVarzaru wants to merge 1 commit intoMariaDB:devfrom
RazvanLiviuVarzaru:MDBF-1186

Conversation

@RazvanLiviuVarzaru
Copy link
Collaborator

Define the locations where the connectors artifacts are published by Buildbot builds

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Defines NGINX locations for where Buildbot publishes connector artifacts in CI.

Changes:

  • Add NGINX location blocks for ODBC, C, and C++ connector artifact paths
  • Map connector URL prefixes to filesystem directories under /srv/buildbot/connectors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RazvanLiviuVarzaru
Copy link
Collaborator Author

@copilot open a new pull request to apply changes based on the comments in this thread

Define the locations where the connectors artifacts
are published by Buildbot builds
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -34,6 +34,18 @@ server {
autoindex off;
}

Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location /connector-odbc/ will not match requests to /connector-odbc (without the trailing slash), which will likely fall through to the server root and 404. Consider adding an exact-match redirect (location = /connector-odbc { return 301 /connector-odbc/; }) or changing the prefix location to /connector-odbc to match both forms.

Suggested change
location = /connector-odbc {
return 301 /connector-odbc/;
}

Copilot uses AI. Check for mistakes.
location /connector-odbc/ {
alias /srv/buildbot/connectors/odbc/;
}

Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location /connector-cpp/ will not match /connector-cpp (no trailing slash), so that common URL will fall back to the server root and likely 404. Add an exact-match redirect to the slash form or remove the trailing slash from the location prefix to accept both.

Suggested change
location = /connector-cpp {
return 301 /connector-cpp/;
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants