Skip to content
/ server Public

Commit 6fe391d

Browse files
committed
Fixed mtr --embedded compat/oracle.sp-package-mdl
Embedded mode produces different thread identifiers, which makes replace_result replace unwanted occurences. Use temporary table for filtering out unwanted threads such that replace_result is not needed anymore. This is regression after 0eebe3a.
1 parent 16311b0 commit 6fe391d

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

mysql-test/suite/compat/oracle/r/sp-package-mdl.result

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,22 @@ connect conn2,localhost,root,,;
2525
SET sql_mode=ORACLE;
2626
DROP PACKAGE pkg1;
2727
connection default;
28-
SELECT ID AS CONN,INFO,STATE,LOCK_MODE,LOCK_TYPE,TABLE_NAME
28+
CREATE TEMPORARY TABLE mythreads(t_id INT UNSIGNED NOT NULL, t_name VARCHAR(16));
29+
INSERT INTO mythreads VALUES(CONNECTION_ID(), 'default_id'),($conn1_id, 'conn1_id'),($conn2_id, 'conn2_id');
30+
SELECT t_name AS CONN,INFO,STATE,LOCK_MODE,LOCK_TYPE,TABLE_NAME
2931
FROM INFORMATION_SCHEMA.PROCESSLIST
32+
INNER JOIN mythreads
33+
ON (ID=t_id)
3034
LEFT JOIN INFORMATION_SCHEMA.METADATA_LOCK_INFO
3135
ON (ID=THREAD_ID)
32-
WHERE ID IN (CONNECTION_ID(), $conn1_id, $conn2_id)
3336
ORDER BY ID,TABLE_NAME,LOCK_MODE,LOCK_TYPE;
3437
CONN default_id
35-
INFO SELECT ID AS CONN,INFO,STATE,LOCK_MODE,LOCK_TYPE,TABLE_NAME
38+
INFO SELECT t_name AS CONN,INFO,STATE,LOCK_MODE,LOCK_TYPE,TABLE_NAME
3639
FROM INFORMATION_SCHEMA.PROCESSLIST
40+
INNER JOIN mythreads
41+
ON (ID=t_id)
3742
LEFT JOIN INFORMATION_SCHEMA.METADATA_LOCK_INFO
3843
ON (ID=THREAD_ID)
39-
WHERE ID IN (CONNECTION_ID(), conn1_id, conn2_id)
4044
ORDER BY ID,TABLE_NAME,LOCK_MODE,LOCK_TYPE
4145
STATE Filling schema table
4246
LOCK_MODE MDL_SHARED_NO_WRITE
@@ -72,6 +76,7 @@ STATE Waiting for stored package body metadata lock
7276
LOCK_MODE MDL_INTENTION_EXCLUSIVE
7377
LOCK_TYPE Schema metadata lock
7478
TABLE_NAME
79+
DROP TABLE mythreads;
7580
DO RELEASE_LOCK('lock');
7681
connection conn1;
7782
pkg1.f1()

mysql-test/suite/compat/oracle/t/sp-package-mdl.test

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,18 @@ WHERE ID=$conn2_id
8484
# to acquire an exclusive MDL on 'package body pkg1',
8585
# to DROP the package pkg1
8686
#
87+
CREATE TEMPORARY TABLE mythreads(t_id INT UNSIGNED NOT NULL, t_name VARCHAR(16));
88+
evalp INSERT INTO mythreads VALUES(CONNECTION_ID(), 'default_id'),($conn1_id, 'conn1_id'),($conn2_id, 'conn2_id');
8789
--vertical_results
88-
let $default_id= `SELECT CONNECTION_ID()`;
89-
--replace_result $conn1_id conn1_id $conn2_id conn2_id $default_id default_id
90-
evalp SELECT ID AS CONN,INFO,STATE,LOCK_MODE,LOCK_TYPE,TABLE_NAME
90+
SELECT t_name AS CONN,INFO,STATE,LOCK_MODE,LOCK_TYPE,TABLE_NAME
9191
FROM INFORMATION_SCHEMA.PROCESSLIST
92+
INNER JOIN mythreads
93+
ON (ID=t_id)
9294
LEFT JOIN INFORMATION_SCHEMA.METADATA_LOCK_INFO
9395
ON (ID=THREAD_ID)
94-
WHERE ID IN (CONNECTION_ID(), $conn1_id, $conn2_id)
9596
ORDER BY ID,TABLE_NAME,LOCK_MODE,LOCK_TYPE;
9697
--horizontal_results
98+
DROP TABLE mythreads;
9799

98100
#
99101
# Now let conn1 finish the package routine execution

0 commit comments

Comments
 (0)