MDEV-37502 mroonga + clang + Debug with exceeds stack frame size

grooverdan · grooverdan · commit f278c7a3e741 · 2025-09-11T10:02:43.000+10:00
Stack limits exceeded for clang-20 +Debug + MSAN.

Added disables for the following functions.

storage/mroonga/vendor/groonga/lib/ii.c:303:1: error: stack frame size (16696) exceeds limit (16384) in 'buffer_segment_reserve' [-Werror,-Wframe-larger-than]
 303 | buffer_segment_reserve(grn_ctx *ctx, grn_ii *ii,
     | ^
storage/mroonga/vendor/groonga/lib/ii.c:4803:1: error: stack frame size (20936) exceeds limit (16384) in 'grn_ii_delete_one' [-Werror,-Wframe-larger-than]
4803 | grn_ii_delete_one(grn_ctx *ctx, grn_ii *ii, grn_id tid, grn_ii_updspec *u, grn_hash *h)
     | ^
storage/mroonga/vendor/groonga/lib/ii.c:6313:1: error: stack frame size (25736) exceeds limit (16384) in 'grn_ii_column_update' [-Werror,-Wframe-larger-than]
6313 | grn_ii_column_update(grn_ctx *ctx, grn_ii *ii, grn_id rid, unsigned int section,
     | ^

For non-Debug the following stack frame sizes wher exceeded:

storage/mroonga/vendor/groonga/lib/proc/proc_select.c:3575:1: warning: stack frame size (94072) exceeds limit (49152) in 'command_select' [-Wframe-larger-than]
 3575 | command_select(grn_ctx *ctx, int nargs, grn_obj **args, grn_user_data *user_data)
      | ^
storage/mroonga/vendor/groonga/lib/proc/proc_schema.c:1134:1: warning: stack frame size (98360) exceeds limit (49152) in 'command_schema_output_tables' [-Wframe-larger-than]
 1134 | command_schema_output_tables(grn_ctx *ctx, grn_schema_data *data)

Reviewer: Jimmy Hu &lt;jimmy.hu@mariadb.com&gt;
diff --git a/storage/mroonga/vendor/groonga/lib/ii.c b/storage/mroonga/vendor/groonga/lib/ii.c
@@ -300,6 +300,8 @@ buffer_segment_new(grn_ctx *ctx, grn_ii *ii, uint32_t *segno)
   }
 }
 
+PRAGMA_DISABLE_CHECK_STACK_FRAME
+
 static grn_rc
 buffer_segment_reserve(grn_ctx *ctx, grn_ii *ii,
                        uint32_t *lseg0, uint32_t *pseg0,
@@ -386,6 +388,8 @@ buffer_segment_reserve(grn_ctx *ctx, grn_ii *ii,
   return ctx->rc;
 }
 
+PRAGMA_REENABLE_CHECK_STACK_FRAME
+
 #define BGQENQUE(lseg) do {\
   if (ii->header->binfo[lseg] != GRN_II_PSEG_NOT_ASSIGNED) {\
     ii->header->bgqbody[ii->header->bgqhead] = ii->header->binfo[lseg];\
@@ -4529,8 +4533,6 @@ grn_ii_get_disk_usage(grn_ctx *ctx, grn_ii *ii)
 }
 
 
-PRAGMA_DISABLE_CHECK_STACK_FRAME
-
 #define BIT11_01(x) ((x >> 1) & 0x7ff)
 #define BIT31_12(x) (x >> 12)
 
@@ -4808,7 +4810,6 @@ exit :
   return ctx->rc;
 }
 
-PRAGMA_REENABLE_CHECK_STACK_FRAME
 
 grn_rc
 grn_ii_delete_one(grn_ctx *ctx, grn_ii *ii, grn_id tid, grn_ii_updspec *u, grn_hash *h)
diff --git a/storage/mroonga/vendor/groonga/lib/proc/proc_schema.c b/storage/mroonga/vendor/groonga/lib/proc/proc_schema.c
@@ -1130,6 +1130,8 @@ command_schema_output_table(grn_ctx *ctx,
   grn_ctx_output_map_close(ctx);
 }
 
+PRAGMA_DISABLE_CHECK_STACK_FRAME
+
 static void
 command_schema_output_tables(grn_ctx *ctx, grn_schema_data *data)
 {
@@ -1201,6 +1203,8 @@ command_schema_output_tables(grn_ctx *ctx, grn_schema_data *data)
   GRN_OBJ_FIN(ctx, &table_ids);
 }
 
+PRAGMA_REENABLE_CHECK_STACK_FRAME
+
 static grn_obj *
 command_schema(grn_ctx *ctx, int nargs, grn_obj **args, grn_user_data *user_data)
 {
diff --git a/storage/mroonga/vendor/groonga/lib/proc/proc_select.c b/storage/mroonga/vendor/groonga/lib/proc/proc_select.c
@@ -3569,7 +3569,6 @@ grn_select_data_fill_drilldowns(grn_ctx *ctx,
     return succeeded;
   }
 }
-PRAGMA_REENABLE_CHECK_STACK_FRAME
 
 static grn_obj *
 command_select(grn_ctx *ctx, int nargs, grn_obj **args, grn_user_data *user_data)
@@ -3723,6 +3722,8 @@ exit :
   return NULL;
 }
 
+PRAGMA_REENABLE_CHECK_STACK_FRAME
+
 #define N_VARS 26
 #define DEFINE_VARS grn_expr_var vars[N_VARS]
 

Original file line number	Diff line number	Diff line change
`@@ -300,6 +300,8 @@ buffer_segment_new(grn_ctx ctx, grn_ii ii, uint32_t *segno)`
`300`	`300`	`}`
`301`	`301`	`}`
`302`	`302`
	`303`	`+PRAGMA_DISABLE_CHECK_STACK_FRAME`
	`304`	`+`
`303`	`305`	`static grn_rc`
`304`	`306`	`buffer_segment_reserve(grn_ctx ctx, grn_ii ii,`
`305`	`307`	`uint32_t lseg0, uint32_t pseg0,`
`@@ -386,6 +388,8 @@ buffer_segment_reserve(grn_ctx ctx, grn_ii ii,`
`386`	`388`	`return ctx->rc;`
`387`	`389`	`}`
`388`	`390`
	`391`	`+PRAGMA_REENABLE_CHECK_STACK_FRAME`
	`392`	`+`
`389`	`393`	`#define BGQENQUE(lseg) do {\`
`390`	`394`	`if (ii->header->binfo[lseg] != GRN_II_PSEG_NOT_ASSIGNED) {\`
`391`	`395`	`ii->header->bgqbody[ii->header->bgqhead] = ii->header->binfo[lseg];\`
`@@ -4529,8 +4533,6 @@ grn_ii_get_disk_usage(grn_ctx ctx, grn_ii ii)`
`4529`	`4533`	`}`
`4530`	`4534`
`4531`	`4535`
`4532`		`-PRAGMA_DISABLE_CHECK_STACK_FRAME`
`4533`		`-`
`4534`	`4536`	`#define BIT11_01(x) ((x >> 1) & 0x7ff)`
`4535`	`4537`	`#define BIT31_12(x) (x >> 12)`
`4536`	`4538`
`@@ -4808,7 +4810,6 @@ exit :`
`4808`	`4810`	`return ctx->rc;`
`4809`	`4811`	`}`
`4810`	`4812`
`4811`		`-PRAGMA_REENABLE_CHECK_STACK_FRAME`
`4812`	`4813`
`4813`	`4814`	`grn_rc`
`4814`	`4815`	`grn_ii_delete_one(grn_ctx ctx, grn_ii ii, grn_id tid, grn_ii_updspec u, grn_hash h)`
Original file line number	Diff line number	Diff line change
`@@ -1130,6 +1130,8 @@ command_schema_output_table(grn_ctx *ctx,`
`1130`	`1130`	`grn_ctx_output_map_close(ctx);`
`1131`	`1131`	`}`
`1132`	`1132`
	`1133`	`+PRAGMA_DISABLE_CHECK_STACK_FRAME`
	`1134`	`+`
`1133`	`1135`	`static void`
`1134`	`1136`	`command_schema_output_tables(grn_ctx ctx, grn_schema_data data)`
`1135`	`1137`	`{`
`@@ -1201,6 +1203,8 @@ command_schema_output_tables(grn_ctx ctx, grn_schema_data data)`
`1201`	`1203`	`GRN_OBJ_FIN(ctx, &table_ids);`
`1202`	`1204`	`}`
`1203`	`1205`
	`1206`	`+PRAGMA_REENABLE_CHECK_STACK_FRAME`
	`1207`	`+`
`1204`	`1208`	`static grn_obj *`
`1205`	`1209`	`command_schema(grn_ctx ctx, int nargs, grn_obj args, grn_user_data user_data)`
`1206`	`1210`	`{`
Original file line number	Diff line number	Diff line change
`@@ -3569,7 +3569,6 @@ grn_select_data_fill_drilldowns(grn_ctx *ctx,`
`3569`	`3569`	`return succeeded;`
`3570`	`3570`	`}`
`3571`	`3571`	`}`
`3572`		`-PRAGMA_REENABLE_CHECK_STACK_FRAME`
`3573`	`3572`
`3574`	`3573`	`static grn_obj *`
`3575`	`3574`	`command_select(grn_ctx ctx, int nargs, grn_obj args, grn_user_data user_data)`
`@@ -3723,6 +3722,8 @@ exit :`
`3723`	`3722`	`return NULL;`
`3724`	`3723`	`}`
`3725`	`3724`
	`3725`	`+PRAGMA_REENABLE_CHECK_STACK_FRAME`
	`3726`	`+`
`3726`	`3727`	`#define N_VARS 26`
`3727`	`3728`	`#define DEFINE_VARS grn_expr_var vars[N_VARS]`
`3728`	`3729`