remove redundant dispose code in SafeDataReader#4607
Closed
SimonCropp wants to merge 3 commits intoMarimerLLC:mainfrom
SimonCropp:remove-redundant-dispose-code-in-SafeDataReader
Closed
remove redundant dispose code in SafeDataReader#4607SimonCropp wants to merge 3 commits intoMarimerLLC:mainfrom SimonCropp:remove-redundant-dispose-code-in-SafeDataReader
SimonCropp wants to merge 3 commits intoMarimerLLC:mainfrom
SimonCropp:remove-redundant-dispose-code-in-SafeDataReader
Conversation
StefanOssendorf
requested changes
Mar 23, 2025
Contributor
There was a problem hiding this comment.
This class is public and has to implement Dispose. Why do you remove the default implementation code for IDisposable for classes which can be derived from?
I don't know if this is actually used in the wild but it's public and someone deriving from this class must have a way to add code to the disposing.
So I'm against this change.
Contributor
Author
|
the |
Contributor
|
That's right. But we don't know what a user of our class does. So we should provide the necessary hook to participate in a proper disposal, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.