Replace duplicate dictionary lookups with TryGetValue and cached locals#4842
Merged
StefanOssendorf merged 1 commit intoMarimerLLC:mainfrom Mar 15, 2026
Conversation
Contributor
SimonCropp
commented
Mar 13, 2026
SimonCropp
commented
- UndoableBase: cache state[fieldName] in a local variable instead of looking it up three times during undo operations
- UndoableBase/FieldDataManager: replace ContainsKey + GetRequiredValue with single TryGetValue call for _stateStack deserialization
- FieldDataManager: replace ContainsKey + GetValue with single TryGetValue for child property lookup, also caching the concatenated key to avoid redundant string allocation
- Remove unnecessary double cast in _stateStack deserialization
- UndoableBase: cache state[fieldName] in a local variable instead of
looking it up three times during undo operations
- UndoableBase/FieldDataManager: replace ContainsKey + GetRequiredValue
with single TryGetValue call for _stateStack deserialization
- FieldDataManager: replace ContainsKey + GetValue with single TryGetValue
for child property lookup, also caching the concatenated key to avoid
redundant string allocation
- Remove unnecessary double cast in _stateStack deserialization
SimonCropp
deleted the
Replace-duplicate-dictionary-lookups-with-TryGetValue-and-cached-locals
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.