Fail to deploy VM consumes network lease

[MarioRobres]

/!\ To report a security issue please follow this procedure:
[https://github.com/OpenNebula/one/wiki/Vulnerability-Management-Process]

Description
When VM is deployed by scheduler and the deployment fails (because of wrong DS type). The deployment is repeated each Scheduler cycle and each time it consumes one network lease, which is never released.

To Reproduce
Prerequisites:

• Image datastore type shared
• System datastore type local
• Virtual Network with available leases
• VM Template using image from shared datastore and NIC=[NETWORK_MODE="auto" ]

Execute onetemplate instantiate <id>

• Wait until Scheduler plans deployment of the VM.
• With each Scheduler cycle error appears in the oned.log:[deploy] Image Datastore does not support transfer mode: local - this is expected
• See onevnet show <vnet_id> the number of leases assigned to the VM is increasing. onevm terminate doesn't free the leases.

Expected behavior
Network lease is released after the deployment fails

Details

• Affected Component: Scheduler, Core
• Hypervisor: kvm
• Version: 7.0.1

Additional context
Check other possible deployment failures: not enough capacity on host, driver failures, ...
Check also used network quotas

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)