Release 0.12.1: require fileutils before OpenApiImport.from#7
Merged
Release 0.12.1: require fileutils before OpenApiImport.from#7
Conversation
Avoid uninitialized constant when the gem is required without another stdlib dependency loading FileUtils first. Bump to 0.12.1 and add a regression spec. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenApiImport.fromcalledFileUtils.rm_fwithout ensuring the stdlib was loaded, so barerequire "open_api_import"could raiseuninitialized constant OpenApiImport::FileUtils.require "fileutils"in the gem entrypoint and use::FileUtils.rm_fat the call site.CHANGELOG.md.FileUtilsis defined after requiring the gem.Test plan
bundle exec rubocop(targeted files)bundle exec rspec spec/open_api_import/fileutils_require_spec.rbMade with Cursor