Add try catch for reading incoming packets#29
Merged
MariusRumpf merged 2 commits intoMariusRumpf:masterfrom Jul 6, 2016
Merged
Add try catch for reading incoming packets#29MariusRumpf merged 2 commits intoMariusRumpf:masterfrom
MariusRumpf merged 2 commits intoMariusRumpf:masterfrom
Conversation
It seems there was quite often a packet coming in that could not be read, it gave RangeError’s when trying to read it. By catching it we at least prevent the code from crashing when such a packet comes in. Further examination is needed to figure out what is “wrong” with these incoming packets.
Current coverage is 57.09%
@@ master #29 diff @@
=========================================
Files 42 42
Lines 2135 1249 -886
Methods 103 103
Messages 0 0
Branches 193 194 +1
=========================================
- Hits 2135 713 -1422
- Misses 0 536 +536
Partials 0 0
|
The code sometimes crashes as an invalid port number is provided (out of range), this makes sure to use the default in those cases.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems there is quite often a packet coming in that could not be
read, it gave RangeError’s when trying to read it. By catching it we at
least prevent the code from crashing when such a packet comes in.
Further examination is needed to figure out what is “wrong” with these
incoming packets.