Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Standardized action/message responses to
ApiMessageResponseDTOacross key controllers, including root/home and admin cache clear endpoints, improving response consistency for clients.Hardened actuator/security behavior by limiting dev actuator exposure and enforcing
EndpointRequestrules (health/infopublic, all other actuator endpoints ADMIN-only).Strengthened notification permission checks in service layer with actor-context validation across board/project/task contexts and admin override; also tightened
markAllAsReadactor/target scope rules.Improved deprecation hygiene by marking email-path aliases as deprecated (
Use /me variant), keeping principal-equality guards, delegating to/mehandlers, and hiding deprecated aliases from OpenAPI.Type of change
Validation
Commands run:
./gradlew test detekt jacocoTestReport sonarqubeDocs impact
Security impact
Actuator exposure in application-dev.yml is restricted to health,info,env,mappings,metrics.
SecurityConfig uses actuator-aware rules:
- EndpointRequest.to("health","info") => permitAll
- EndpointRequest.toAnyEndpoint() => requires ADMIN
Notification service permission model now validates actor context for board/project/task and enforces non-admin self-scope on markAllAsRead.
Deprecated email-path aliases remain for compatibility but are hidden from OpenAPI and guarded by principal equality checks.