Refactor notification authorization to use membership repositories#38
Closed
MarkADom wants to merge 1 commit intorelease/v1.0.0-finalizefrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
board.members,project.projectMembers, andtask.membersinNotificationServicewith repository calls toexistsByBoardIdAndUserId,existsByProjectIdAndUserId, andexistsByTaskIdAndUserIdrespectively.BoardMemberRepository,ProjectMemberRepository, andTaskMemberRepositoryintoNotificationServiceand used actor id lookups for repository-based authorization while keeping aggregates intact.NotificationServiceTestto mock the new member repositories, adapt board/project/task test fixtures, and add verifications that the membership repository methods are invoked for authorization.Testing
NotificationServiceTestnow includes mocks forBoardMemberRepository,ProjectMemberRepository, andTaskMemberRepositoryand asserts repository method calls for board/project/task authorization; these test changes are committed.io.gitlab.arturbosch.detekt), so automated runs did not complete.Codex Task