Nested includes do not get live reloaded

[nicholaschuayunzhi]

Stumbled upon a bug when trying to improve build time for live reloading.

BUG: Anything nested in two levels of dynamic include do not get updated.

Set up

site.json

{ 
  "baseUrl": "",
  "pages": [
    {
      "src": "index.md",
      "title": "Hello World"
    }
  ],
  "ignore": [
    "_site/*",
    "site.json"
  ],
  "deploy": {
    "message": "Site Update."
  }
}

index.md

<include src="include1.md" dynamic />

include1.md

<include src="include2.md" dynamic />

Any changes here will be reloaded correctly

include2.md

Any changes here will NOT be reloaded correctly

Steps

1. run $ markbind serve
2. make a change to text in include2.md and save
3. site reloads but content in the nested dynamic panel is unchanged

Additional Notes

• after applying steps 1 - 3, a change to include1.md will update the include1's content correctly but the include2 content is still unchanged

[nicholaschuayunzhi]

Removing this check resolves the problem for the set up above

https://github.com/MarkBind/markbind-cli/blob/54697812e9ef554ef5d613f4df8210160de3467e/lib/Page.js#L138-L147

// Page.js in markbind-cli
    let fileExists;
    try {
      fileExists = fs.statSync(resultPath).isFile();
    } catch (e) {
      fileExists = false;
    }
    // File exists, return.
    if (fileExists) {
      return resolve();
    }

Edit: I believe the above is an optimization for building a site that includes the same file multiple times. But when doing live reload of a page we need to overwrite existing include.htmls. Perhaps, I can specify a flag for this?

[nicholaschuayunzhi]

I found a case in website-base for CS2103.

Steps to Reproduce

1. $ markbind serve
2. Make changes to \website-base\book\codeQuality\practices\useNameExplain\text.md
3. Wait for live reload
4. Week12 -> Todo -> Admin >> Project v1.5rc -> Tips how to score high for code ... -> code quality guidelines -> Guideline: Namewell -> Intermediate -> Use name to explain well
5. Changes made not updated here

[nicholaschuayunzhi]

Update: removing https://github.com/MarkBind/markbind-cli/blob/54697812e9ef554ef5d613f4df8210160de3467e/lib/Page.js#L138-L147 resolves this issue, but comes with longer build time. Have not timed it yet.