Merged
Conversation
This reverts commit a9d1973.
ang-zeyu
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Potentially fixes #1703 and fixes #1704
Anything you'd like to highlight / discuss:
I am using the solution proposed by other devs, which is to
I am not too sure if this works correctly because we use lerna and I can see some issues with certain packages using other versions of colorsjs that are outdated. However, all the test cases do pass locally after I adjusted the package.json. Also, I am not too sure how to test this fix and hence trying to put this PR up to see if it works in CI?
Testing instructions:
nil
Proposed commit message: (wrap lines at 72 characters)
Pin colorsjs at version 1.4.0
Checklist: ☑️