Invoke plantuml jar from the respective working directory#2344
Merged
tlylt merged 1 commit intoMarkBind:masterfrom Aug 5, 2023
Merged
Invoke plantuml jar from the respective working directory#2344tlylt merged 1 commit intoMarkBind:masterfrom
tlylt merged 1 commit intoMarkBind:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #1752
Style file inclusion was not working properly as we invoke the plantuml jar file at the root directory, hence the file path resolution cannot find the correct style.puml. This fix configures the call the plantuml executable to use the output folder that contains the .puml to be the current working directory. This helps with relative path resolution when a .puml includes other .puml files.
Anything you'd like to highlight/discuss:
nil
Testing instructions:
npm run build:backendProposed commit message: (wrap lines at 72 characters)
Invoke plantuml jar from the respective working directory
Checklist: ☑️