Fix core logger to log error objects properly#2864
Merged
gerteck merged 1 commit intoMarkBind:masterfrom Mar 22, 2026
Merged
Conversation
When logging error objects without transformation winston logs `undefined` To improve traceability, Update console logging format and winston configuration to use `format.errors` to log a stack trace.
There was a problem hiding this comment.
Pull request overview
Updates the core Winston logger configuration so Error objects are formatted correctly (including stack traces) when logged.
Changes:
- Adds Winston’s
format.errors({ stack: true })to the console log format pipeline. - Moves the
formatconfiguration from the Console transport to the globalwinston.configure()options.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2864 +/- ##
=======================================
Coverage 71.99% 71.99%
=======================================
Files 132 132
Lines 7352 7352
Branches 1534 1633 +99
=======================================
Hits 5293 5293
Misses 1958 1958
Partials 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gerteck
approved these changes
Mar 22, 2026
Member
gerteck
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Updates winston configuration in core to properly handle error objects in logging.
Anything you'd like to highlight/discuss:
nil
Testing instructions:
nil
Proposed commit message: (wrap lines at 72 characters)
Fix core logger to log error objects properly
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):