Skip to content

Fix test workflow#2866

Merged
gerteck merged 2 commits intoMarkBind:masterfrom
gerteck:FixTestWorkflow
Mar 22, 2026
Merged

Fix test workflow#2866
gerteck merged 2 commits intoMarkBind:masterfrom
gerteck:FixTestWorkflow

Conversation

@gerteck
Copy link
Member

@gerteck gerteck commented Mar 22, 2026

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

Fixes #2861

Remove clear cache flag added as it was causing race condition causing test to fail
Also enforce #2630 by adding flag to make sure tests run sequentially by adding concurrency 1 flag.

Issue was due to race condition.

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

Fix flaky CLI tests

Remove clear cache flag causing race condition
Also make tests run sequentially in GH actions


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

gerteck added 2 commits March 22, 2026 13:20
When markbind-cli finishes its test
run tries to write its perf-cache to
same directory, fails as vue-components deleted it.
@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.99%. Comparing base (341b94d) to head (23f01bb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2866    +/-   ##
========================================
  Coverage   71.99%   71.99%            
========================================
  Files         132      132            
  Lines        7352     7352            
  Branches     1629     1511   -118     
========================================
  Hits         5293     5293            
- Misses       1958     2053    +95     
+ Partials      101        6    -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gerteck gerteck merged commit 221b36e into MarkBind:master Mar 22, 2026
12 checks passed
@github-actions github-actions bot added the r.Patch Version resolver: increment by 0.0.1 label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky testcase in CLI on GH Actions

1 participant