Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

Conversation

@Chng-Zhi-Xuan
Copy link

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Enhancement to an existing feature

Part of MarkBind/markbind#335

What is the rationale for this request?
On mobile sites, Panel buttons are mis-aligned and the padding is too generous.

What changes did you make? (Give an overview)

  • Change buttons' CSS to align them
  • Trimmed padding and gave Panel headers more width when rendered on mobile.
Before After
335-panel-before 335-panel-after

Is there anything you'd like reviewers to focus on?

  • New responsive CSS

Testing instructions:

  • Run npm run build and paste the updated vue-strap.min.js into MarkBind's asset folder.
  • Run markbind init, author a panel with popup-url.
  • Run markbind serve and reduce window size.
  • Inspect the new Panel's style.

Copy link
Member

@yamgent yamgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yamgent
Copy link
Member

yamgent commented Jul 17, 2018

When the panels get smaller, the card title will "cover over" the buttons though.

@Chng-Zhi-Xuan
Copy link
Author

As discussed, since CSS is unable to monitor the element's width, there is no solution, especially if the Panel is nested even more.

A future enhancement could be implementing a watcher and transform "squished" Panels to minimised buttons that opens a Modal view.

@yamgent yamgent added this to the v2.0.1-markbind.15 milestone Jul 17, 2018
@yamgent yamgent merged commit a0bae9e into MarkBind:master Jul 18, 2018
@Chng-Zhi-Xuan Chng-Zhi-Xuan deleted the 335-panel-button branch May 27, 2019 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants