Use hidePreviewButtons for side-by-side only#83
Conversation
…te build Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
README.md
Outdated
| - `updateBehavior`: `"quiet"` shows a button, `"notify"` shows an alert, `"never"` disables update checks. | ||
| - `syncScroll`: Whether to enable scroll synchronization. | ||
| - `hidePreviewButtons`: Whether to hide the built-in preview buttons (not applicable for lite build). | ||
| - `hidePreviewButtons`: Whether to hide the built-in preview buttons in side-by-side mode (for lite build, hides preview buttons under table wrappers only). |
…-centric "under table wrappers" Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
|
@copilot Second thoughts made me think if we should add it for lite build at all, it feels inconsistent and harder to understand the pattern, what do you think as a senior product person? |
Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
I agree — the inconsistency hurts more than it helps. In full build, |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the hidePreviewButtons behavior so it only hides MarkEdit’s built-in preview buttons when the extension is in side-by-side mode, and documents that the setting is intentionally not supported in the lite build.
Changes:
- Scope the CSS selector for
hidePreviewButtonsto.markdown-containerso it only applies in side-by-side mode. - Update inline comment to reflect side-by-side-only behavior.
- Update README setting description to match the new scoping and clarify lite build applicability.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/view.ts | Scopes hidePreviewButtons CSS to the side-by-side container class so other modes retain built-in preview buttons. |
| README.md | Documents that hidePreviewButtons affects side-by-side mode only and is not applicable for the lite build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hidePreviewButtonswas globally hiding.cm-md-previewWrapperin full build only, regardless of view mode. Two improvements:.markdown-container .cm-md-previewWrapper—.markdown-containeris only present in side-by-side mode, so preview buttons remain visible in other modeshidePreviewButtonspartially work (only table buttons) in lite would be confusing. This follows the same pattern assyntaxAutoDetect.hidePreviewButtonsas not applicable for lite buildOriginal prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.