Merged
Conversation
Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
cyanzhong
March 16, 2026 05:48
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “Ignore” behavior in the diagnostic card helpers so that ignoring a flagged word can clear all matching occurrences (by text + lint kind), aligning UI highlights with dictionary additions.
Changes:
- Change
ignoreDiagnosticfiltering from positional matching (from/to) to semantic matching (problemText/lintKind).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
|
@copilot Do we need to check kind? |
…iagnostic tests Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking "Ignore" on a flagged word only dismissed that single occurrence. Other identical flagged words remained highlighted despite the word being added to the dictionary.
ignoreDiagnosticfilter predicate from positional matching (from/to) to semantic matching byproblemTextonly (lint kind is not checked, since the word is added to the dictionary regardless of kind)problemTextis empty, falls back to positional matching (from/to/lintKind) to avoid over-removing unrelated diagnosticsignoreDiagnosticcovering: all same-text removal, cross-kind removal, different-text preservation, and empty-text positional fallback💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.