Test/global actions#7955
Merged
david-yz-liu merged 13 commits intoMay 20, 2026
Merged
Conversation
Collaborator
david-yz-liu
left a comment
There was a problem hiding this comment.
@akarki2005 in addition to the inline comments I left, I see that the pre-commit bot made some updates to your branch. This indicates that you haven't set up the pre-commit hooks properly in your local repository, so please make sure to do so before making another commit.
# Conflicts: # Changelog.md
for more information, see https://pre-commit.ci
…arkUsProject#7949) # Conflicts: # Changelog.md
# Conflicts: # Changelog.md
543b2e7 to
4eb7fd0
Compare
Collaborator
Coverage Report for CI Build 26184493151Coverage increased (+0.03%) to 90.209%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
david-yz-liu
approved these changes
May 20, 2026
Collaborator
david-yz-liu
left a comment
There was a problem hiding this comment.
Nice work, @akarki2005!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds missing test coverage for three private helper methods called through
GroupsController#global_actions:check_for_groupings: raises when no groupings are selectedadd_members: raises when 2+ groupings are selected, no students are selected, or group_max would be exceededadd_member: sets:inviterstatus when grouping is empty, raises when student is already grouped, raises when student cannot be invited (different course), and flashes error when student has insufficient grace creditsType of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request: