Fix a few issues with the install.sh script#125
Closed
ColinChartier wants to merge 1 commit intoMarkUsProject:masterfrom
ColinChartier:fixup_install_script
Closed
Fix a few issues with the install.sh script#125ColinChartier wants to merge 1 commit intoMarkUsProject:masterfrom ColinChartier:fixup_install_script
ColinChartier wants to merge 1 commit intoMarkUsProject:masterfrom
ColinChartier:fixup_install_script
Conversation
Contributor
ColinChartier
commented
Oct 14, 2018
ColinChartier
commented
- Add bash security line to fail fast (set -eu -o pipefail)
- Fix issues where running the script outside of the venv would fail
- chown the serveruser directory to avoid permission issues
- Add bash security line to fail fast (set -eu -o pipefail) - Fix issues where running the script outside of the venv would fail - chown the serveruser directory to avoid permission issues
mishaschwartz
added
the
to revisit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.