Fix user agent string to be RFC 7231 compliant#5
Merged
MarketDataDev01 merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
Changed user agent format from 'marketdata-sdk-py-{version}' to
'marketdata-sdk-py/{version}' to comply with RFC 7231 specification
which requires product/version format.
- Updated _get_user_agent() method in client.py
- Updated corresponding tests in test_client.py
- Updated README.md documentation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 2113 2113
=========================================
Hits 2113 2113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarketDataDev01
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changed user agent format from
marketdata-sdk-py-{version}tomarketdata-sdk-py/{version}to comply with RFC 7231 specification which requiresproduct/versionformat.Changes Made
_get_user_agent()method inclient.pytest_client.pyTesting
All tests pass (23/23 client tests passed).
RFC 7231 Compliance
Per RFC 7231 Section 5.5.3, the User-Agent header must follow the format:
The previous format used a hyphen separator which is not compliant. The new format uses a forward slash as required by the specification.