Add optional endpoint_url to s3 keywords #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@teaglebuilt Would it be possbile to get this merged? |
Contributor
Author
|
@teaglebuilt Is there anything wrong with the PR? Could you please give me more information why this can't be merged? |
adrianyorke
reviewed
May 4, 2020
Collaborator
adrianyorke
left a comment
adrianyorke
left a comment
There was a problem hiding this comment.
If you remove region then existing test automation scripts may fail.
Collaborator
|
@adrianyorke @Jakob-em is this ready to be merged? |
Contributor
Author
|
@teaglebuilt I added the |
Collaborator
|
Thanks for the PR and region fix @Jakob-em. |
|
@Jakob-em do you plan a release with this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it possible to use an s3 mock implementaion like https://hub.docker.com/r/adobe/s3mock