Only one screenshot per log is saved

[chsinger]

Describe the bug
Only one screenshot is saved per log: TESTCASENAME_FAILURE_SCREENSHOT.png and the screenshot is not directly visible in the log file (just the link).

To Reproduce
Steps to reproduce the behavior:

1. Run a testsuite with failing testcases.
2. Open the log :)
3. Rerun the testcases with the same log directory

Expected behavior

• For every failed teststep a screenshot is saved and displayed in the log.
• Existing screenshots are not overwritten.

[mkorpela]

@all-contributors please add tuxmux28 for testing

[allcontributors]

@mkorpela

I've put up a pull request to add @tuxmux28! 🎉

[xylix]

@tuxmux28 We considered a couple options with @mkorpela . Would a fine solution be to create a unique screenshot directory per run (so for example on library init we create a folder named -testrun-screenshots) and then save the screenshots in that? This would allow grouping of screenshots for a test run since they would be in the same directory.

[mkorpela]

So this would be inside of the output dir.

[chsinger]

A unique screenshot directory would be great 👍

[xylix]

This is now fixed with c58de61 . We added rolling indexing to default failure screenshot filenames and optional SL style {index} replacing with rolling indice in custom filenames.