Demo app loggin

[aaltat]

No description provided.

[Copilot]

Pull request overview

Adds request logging to the dynamic test app and captures its output into per-port log files to make debugging automated test runs easier.

Changes:

• Add morgan (and types) and bump @yao-pkg/pkg.
• Enable HTTP request logging middleware in node/dynamic-test-app server.
• Redirect test server stdout/stderr into atest/output/test-app/test-app-<port>.log and close logs on shutdown.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File	Description
package.json	Adds morgan (+ types) to support request logging; bumps @yao-pkg/pkg.
package-lock.json	Lockfile updates reflecting new/updated npm dependencies.
node/dynamic-test-app/src/server.ts	Wires morgan into the Express app to log requests.
atest/library/common.py	Redirects test server output to log files and closes them in stop_test_server.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

[Copilot]

In stop_test_server, if close_process_tree(p) raises (e.g., psutil AccessDenied/other unexpected errors), the corresponding log file handle in LOG_FILES will not be flushed/closed because that cleanup happens after the process shutdown block. Consider wrapping the process shutdown in a try/finally (or otherwise guaranteeing log-file cleanup) so log handles don’t leak on teardown failures.

Suggested change

	if port in SERVERS:
	p: Popen = SERVERS[port]
	close_process_tree(p)
	del SERVERS[port]
	else:
	logger.warn(f"Server with port {port} not found")
	if port in LOG_FILES:
	LOG_FILES[port].flush()
	LOG_FILES[port].close()
	del LOG_FILES[port]
	try:
	if port in SERVERS:
	p: Popen = SERVERS[port]
	close_process_tree(p)
	del SERVERS[port]
	else:
	logger.warn(f"Server with port {port} not found")
	finally:
	if port in LOG_FILES:
	LOG_FILES[port].flush()
	LOG_FILES[port].close()
	del LOG_FILES[port]