Remove deprecated#4946
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated functionality and its associated tests from the Browser library, reducing maintenance surface by deleting legacy helpers and an obsolete waiting keyword.
Changes:
- Removed
Browser/utils/deprecated.py(deprecated helper utilities) and its unit tests. - Removed the deprecated Robot Framework keyword
Wait Until Network Is IdlefromBrowser/keywords/network.py. - Removed the acceptance test case that exercised
Wait Until Network Is Idle.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
utest/test_deprecated.py |
Deletes unit tests that covered the removed deprecated helper functions. |
Browser/utils/deprecated.py |
Removes deprecated helper utilities (including positional-arg conversion and deprecation detection). |
Browser/keywords/network.py |
Removes the deprecated wait_until_network_is_idle keyword implementation. |
atest/test/03_Waiting/wait_for_http.robot |
Removes the acceptance test case that used the deprecated keyword. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4945