Skip to content

Add rule related to ignored data#243

Merged
bhirsz merged 3 commits intoMarketSquare:masterfrom
szabolcstoth:rules/ignored_data
Nov 19, 2020
Merged

Add rule related to ignored data#243
bhirsz merged 3 commits intoMarketSquare:masterfrom
szabolcstoth:rules/ignored_data

Conversation

@szabolcstoth
Copy link
Copy Markdown
Contributor

Added rule "0704": checker for ignored data.

Closes #174

Added rule "0704": checker for ignored data.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 19, 2020

Codecov Report

Merging #243 (1f8cff0) into master (2831ab7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   99.06%   99.07%           
=======================================
  Files          33       33           
  Lines        2135     2154   +19     
=======================================
+ Hits         2115     2134   +19     
  Misses         20       20           
Impacted Files Coverage Δ
robocop/checkers/comments.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2831ab7...1f8cff0. Read the comment docs.

Comment thread robocop/checkers/comments.py Outdated
Comment thread tests/atest/rules/ignored-data/test.robot Outdated
Refactored the code so we don't even need to use __init__.
- test.robot: should pass
- with_ignored_data.robot: should fail at the first line
- with_ignored_rule_and_data.robot: should fail at the second line
@bhirsz bhirsz merged commit 417b39a into MarketSquare:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule: Check if there is data before first section

3 participants