Skip to content

Fix issues with counting keyword calls in blocks or with new syntax#704

Merged
bhirsz merged 2 commits intomasterfrom
fix/return_not_counted
Sep 4, 2022
Merged

Fix issues with counting keyword calls in blocks or with new syntax#704
bhirsz merged 2 commits intomasterfrom
fix/return_not_counted

Conversation

@bhirsz
Copy link
Copy Markdown
Member

@bhirsz bhirsz commented Sep 4, 2022

Fixed:

  • the keyword calls are now properly counted inside IFs, inline IFs, TRY EXCEPT blocks
  • new RF 5.0 syntax is now also counted towards keyword calls (such as BREAK, CONTINUE, RETURN statements)

Fixes #629

@bhirsz bhirsz requested a review from mnojek as a code owner September 4, 2022 11:07
@bhirsz bhirsz force-pushed the fix/return_not_counted branch from 1214a76 to 6978ada Compare September 4, 2022 18:48
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 4, 2022

Codecov Report

Base: 97.22% // Head: 97.23% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (defe2f3) compared to base (e6a83b3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   97.22%   97.23%   +0.01%     
==========================================
  Files          24       24              
  Lines        2996     3007      +11     
==========================================
+ Hits         2913     2924      +11     
  Misses         83       83              
Impacted Files Coverage Δ
robocop/checkers/lengths.py 98.42% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bhirsz bhirsz force-pushed the fix/return_not_counted branch from 6978ada to defe2f3 Compare September 4, 2022 18:52
@bhirsz bhirsz merged commit bf2747a into master Sep 4, 2022
@bhirsz bhirsz deleted the fix/return_not_counted branch September 4, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule [too-few-calls-in-keyword] too strict?

2 participants