Skip to content

Conversation

@adrszad
Copy link
Contributor

@adrszad adrszad commented Jul 1, 2021

Spelling issues found and resolved by codespell tool.
There is one more change suggested:
splitted -> split,
but as 'split' is already used along 'splitted' multiple times I did not resolve this in this PR.

@adrszad adrszad requested review from bhirsz and mnojek as code owners July 1, 2021 15:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

Merging #146 (6ed291b) into main (f212afd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   97.04%   97.04%           
=======================================
  Files          24       24           
  Lines        1288     1288           
=======================================
  Hits         1250     1250           
  Misses         38       38           
Impacted Files Coverage Δ
robotidy/cli.py 93.83% <ø> (ø)
robotidy/transformers/SmartSortKeywords.py 96.00% <ø> (ø)
robotidy/transformers/ReplaceRunKeywordIf.py 98.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f212afd...6ed291b. Read the comment docs.

@bhirsz
Copy link
Member

bhirsz commented Jul 2, 2021

Splendid idea - in particular because I'm prone to typos 😄. Do you think it's good idea to add this check (in the future) to our Github Actions? As separate pipeline.

Regarding splitted you can replace it to split while you're at it. If it's used together with split you can replace it with part - for example:

split = order.lower().split(',')
if any(part not in default for part in split):

or you can go even further and in some case replace splitted with parts. Using above example:

parts = order.lower().split(',')
if any(part not in default for part in parts):

It's also arguable if we sometimes do even need variable splitted? If we are not using it anywhere else:

if any(part not in default for part in order.lower().split(',')):

What do you think, what would be best option?

@adrszad
Copy link
Contributor Author

adrszad commented Jul 2, 2021

I resolved 'splitted' typo with second suggestion : )
I think it's good idea to add it to github actions, it can be also used locally as pre-commit hook. This tool is also highly configurable with some custom dictionaries, whitelists etc.

@bhirsz
Copy link
Member

bhirsz commented Jul 2, 2021

Thanks - and I will create issue for spell checks Action.

@bhirsz bhirsz merged commit 8ca3612 into MarketSquare:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants